MAINT/TST/DOC: backend/frontend refactoring #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramp-database/requirements.txt
Outdated
| click | ||
| gitpython | ||
| ipykernel | ||
| jupyter |
ramp-database/requirements.txt
Outdated
| @@ -0,0 +1,9 @@ | |||
| click | |||
There was a problem hiding this comment.
do we need this file?
ramp-engine/rampbkd/dispatcher.py
Outdated
| # TODO: test those two last functions | ||
| update_leaderboards(self._ramp_config['event_name']) | ||
| update_all_user_leaderboards(self._ramp_config['event_name']) | ||
| # update_leaderboards(self._ramp_config['event_name']) |
ramp-frontend/README.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| # RAMP front-end | |||
|
|
|||
| This the repository for the RAMP website. | |||
There was a problem hiding this comment.
Can you add the README content of the current databoard package?
ramp-frontend/setup.py
Outdated
| packages=find_packages(), | ||
| install_requires=INSTALL_REQUIRES, | ||
| entry_points={ | ||
| 'console_scripts': ['frontend = frontend.cli:start'] |
There was a problem hiding this comment.
Suggested change
| 'console_scripts': ['frontend = frontend.cli:start'] | |
| 'console_scripts': ['ramp-frontend = frontend.cli:start'] |
| ramp_config['ramp_kits_dir'], | ||
| ramp_config['event'], | ||
| 'submissions' | ||
| ) | ||
| ramp_config['ramp_submissions_dir'] = os.path.join( |
There was a problem hiding this comment.
needs to be relative to the config file here
ramp-utils/setup.py
Outdated
| @@ -48,5 +48,8 @@ | |||
| platforms='any', | |||
| packages=find_packages(), | |||
| package_data=PACKAGE_DATA, | |||
| entry_points={ | |||
| 'console_scripts': ['utils = ramputils.cli:start'] | |||
There was a problem hiding this comment.
Suggested change
| 'console_scripts': ['utils = ramputils.cli:start'] | |
| 'console_scripts': ['ramp-utils = ramputils.cli:start'] |
tasks.py
Outdated
| @@ -1,330 +0,0 @@ | |||
| from __future__ import print_function, unicode_literals | |||
|
|
|||
There was a problem hiding this comment.
maybe just keep this file until we moved them all to click commands?
glemaitre
force-pushed
the
frontend_small_diff
branch
from
ee5171e to
c906b7e
Compare
glemaitre
changed the title
| from .submission import get_bagged_scores | ||
| from .submission import get_scores | ||
| from .submission import get_submission_max_ram | ||
| from .submission import get_time | ||
|
|
||
| pd.set_option('display.max_colwidth', -1) |
There was a problem hiding this comment.
Small note: this will do that session wide, if you only want to do that for a specific call, there is a similar with pd.option_context(..): as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
closes #114
closes #109
closes #110
closes #111
closes #107
closes #100
closes #96
closes #92