Use placeholder expression when replacing unused symbols #8358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a case where our currently limited form of inner-module tree shaking determined
b
andb2
to be unused (since onlya
was imported). But then we still have thevar $id$export$id = $id$import$b;
declaration in the output.The RHS was previously replaced with a reference to an asset that doesn't exist (because is was skipped).
After:
(Also note that this is not the common case, for unused
export { ... }
declarations, there is nothing in the asset and the packager doesn't generate the$parcel$export
call in the first place. So there is no problematic placeholder as in the added test case).