-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS Code Extension for Parcel #8139
Conversation
…ostics when Parcel is started before the extension and vice versa
I think it would be nice to always show something in the status bus when the extension is connected to a Parcel instance (similar to the Flow extension, so like a static progress message)? |
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
Three.js ✅
Timings
Cold Bundles
Cached Bundles
|
3c5fc5a
to
5d13e86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we wanna merge this and iterate or is this waiting for something?
@devongovett Yeah we could probably merge this. I think I was just waiting to publish the extension to the Marketplace but I can do that in a separate task |
* upstream/v2: (22 commits) Cross compile toolchains are built into docker image already Also fix release build Update centos node version v2.7.0 Changelog for v2.7.0 Use placeholder expression when replacing unused symbols (#8358) Lint (#8359) Add support for errorRecovery option in @parcel/transformer-css (#8352) VS Code Extension for Parcel (#8139) Add multi module compilation for elm (#8076) Bump terser from 5.7.2 to 5.14.2 (#8322) Bump node-forge from 1.2.1 to 1.3.0 (#8271) allow cjs config files on type module projects (#8253) inject script for hmr when there is only normal script in html (#8330) feat: support react refresh for @emotion/react (#8205) Update index.d.ts (#8293) remove charset from jsloader script set (#8346) Log resolved targets in verbose log level (#8254) Fix missing module in large app from Experimental Bundler (#8303) [Symbol Propagation] Non-deterministic bundle hashes (#8212) ...
↪️ Pull Request
How it works
Parcel LSP Reporter
buildProgress
events report information during each Parcel phase and we translate these events into VS Code’s Work Done Progress events.buildFailure
events return an array of ParcelDiagnostic
's, which we translate into VS Code Diagnostics.The reporter will also create a descriptor file that contains information about the Parcel process, and the translated diagnostics will be emitted through the IPC server.
LSP Server
The LSP Server will watch for Parcel descriptors created by the reporter, establish an IPC client connection for each Parcel process, and report the diagnostics that are received from the reporter to each client.
How to use it
https://github.com/parcel-bundler/parcel/blob/vscode-extension/packages/utils/parcelforvscode/README.md
Todo
💻 Examples
Build phase progress messages in VS Code
Parcel diagnostics in VS Code
🚨 Test instructions
✔️ PR Todo