Prevent term-size from being bundled
#7750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`term-size` uses a pre-compiled binary as a fallback on windows and macos. At the moment, the cli-reporter is bundling `term-size`, but doesn't copy these binaries. When running parcel in a non-interactive environment, `term-size` attempts to execute the vendored binaries, but non-fatally reports an error because they don't exist. This happens in cases like Turborepo (i.e. `turbo run build`) or pnpm recursively-run (i.e. `pnpm multi run build`)
|
mischnic
approved these changes
Feb 28, 2022
devongovett
approved these changes
Mar 1, 2022
gorakong
pushed a commit
that referenced
this pull request
Nov 3, 2022
* upstream/v2: (26 commits) Replace typeof before DCE (#7788) Bump lmdb (#7797) Upgrade flow to 0.173.0 (#7809) Prevent `term-size` from being bundled (#7750) Pin [email protected] (#7763) Fix Windows CI (#7774) Upgrade Flow to 0.171.0 (#7667) Move tests to GitHub actions (#7678) v2.3.2 Fix autoinstalling node builtins (#7735) Fix lint Use pinned versions Don't build native packages again during publish step Fix build Fix autoinstall v2.3.1 Add diagnostic for failed autoinstall of node polyfill (#7682) v2.3.0 Changelog for 2.3.0 Support React 18 prereleases and experimental versions with automatic JSX runtime (#7642) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
term-sizeuses a pre-compiled binary as a fallback on windows and macos.At the moment, the cli-reporter is bundling
term-size, but doesn't copy these binaries. When running parcel in a non-interactive environment,term-sizeattempts to execute the vendored binaries, but non-fatally reports an error because they don't exist.This happens in cases like Turborepo (i.e.
turbo run build) or pnpm recursively-run (i.e.pnpm multi run build)↪️ Pull Request
💻 Examples
🚨 Test instructions
✔️ PR Todo