Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 18 prereleases and experimental versions with automatic JSX runtime #7642

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

devongovett
Copy link
Member

Fixes #7595. Closes #6948.

@height
Copy link

height bot commented Feb 2, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 11.07s -112.00ms
Cached 527.00ms +34.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 485.44kb +0.00b 6.54s +800.00ms ⚠️
dist/PermalinkedComment.46b19af5.js 4.21kb +0.00b 6.54s +800.00ms ⚠️
dist/UserProfile.f8cd7884.js 1.57kb +0.00b 6.54s +800.00ms ⚠️
dist/NotFound.960ab92b.js 429.00b +0.00b 6.54s +800.00ms ⚠️
dist/logo.c5bb83f1.png 246.00b +0.00b 6.48s +793.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.22m -611.00ms
Cached 1.44s -96.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/editorView.15bc27a4.js 594.92kb +0.00b 54.40s +13.60s ⚠️
dist/popup.f944d52c.js 209.67kb +0.00b 54.40s +13.60s ⚠️
dist/Toolbar.b2284ccb.js 107.23kb +0.00b 54.40s +13.60s ⚠️
dist/Modal.ec0ec3f8.js 45.33kb +0.00b 54.40s +13.60s ⚠️
dist/ui.39c61c40.js 14.94kb +0.00b 54.40s +13.60s ⚠️
dist/smartMediaEditor.27b49d9d.js 13.25kb +0.00b 54.40s +13.60s ⚠️
dist/dropzone.0d17e26c.js 12.16kb +0.00b 54.40s +13.60s ⚠️
dist/EmojiPickerComponent.8fb3dd15.js 3.73kb +0.00b 54.40s +13.60s ⚠️
dist/dropzone.d03df26a.js 3.29kb +0.00b 54.40s +13.60s ⚠️
dist/clipboard.7ceac12b.js 2.93kb +0.00b 54.40s +13.60s ⚠️
dist/ResourcedEmojiComponent.9106318a.js 2.12kb +0.00b 54.40s +13.60s ⚠️
dist/browser.d28fd36c.js 1.69kb +0.00b 54.40s +13.60s ⚠️
dist/media-card-analytics-error-boundary.bead5bf1.js 1.12kb +0.00b 54.40s +13.60s ⚠️
dist/media-picker-analytics-error-boundary.3df18700.js 966.00b +0.00b 54.40s +13.60s ⚠️
dist/simpleHasher.a4c0be3d.js 643.00b +0.00b 54.40s +13.60s ⚠️

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 7.88s -33.00ms
Cached 413.00ms +18.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 90050e4 into v2 Feb 3, 2022
@devongovett devongovett deleted the react-experimental branch February 3, 2022 04:20
gorakong pushed a commit that referenced this pull request Nov 3, 2022
* upstream/v2: (26 commits)
  Replace typeof before DCE (#7788)
  Bump lmdb (#7797)
  Upgrade flow to 0.173.0 (#7809)
  Prevent `term-size` from being bundled (#7750)
  Pin [email protected] (#7763)
  Fix Windows CI (#7774)
  Upgrade Flow to 0.171.0 (#7667)
  Move tests to GitHub actions (#7678)
  v2.3.2
  Fix autoinstalling node builtins (#7735)
  Fix lint
  Use pinned versions
  Don't build native packages again during publish step
  Fix build
  Fix autoinstall
  v2.3.1
  Add diagnostic for failed autoinstall of node polyfill (#7682)
  v2.3.0
  Changelog for 2.3.0
  Support React 18 prereleases and experimental versions with automatic JSX runtime (#7642)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSX automatic transform doesn't get used for 18+ prereleases
3 participants