reporter: refactor for reference based attributes (#1234)#260
Merged
Conversation
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
|
|
# Conflicts: # reporter/samples/samples.go
The parca-agent oomprof path was carrying Allocs/Frees/AllocBytes/FreeBytes on TraceEventMeta as fork-only fields. Replace with a single OriginData any field so origin-specific payload can be carried through the reporter interface without requiring the shared struct to grow per-origin fields. Future upstream changes to TraceEventMeta no longer textually conflict on fork-only field placement; samples.go remains byte-identical to upstream modulo the single OriginData line.
gnurizen
force-pushed
the
claude/origin-data-resolution-20260429-073752
branch
from
5202c10 to
11047f0
Compare
brancz
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge from upstream, move oomprof TraceEventMeta fields to a optional any pointer.