Skip to content

reporter: refactor for reference based attributes#1234

Merged
felixge merged 10 commits into
open-telemetry:mainfrom
florianl:reporter-alpha
Mar 24, 2026
Merged

reporter: refactor for reference based attributes#1234
felixge merged 10 commits into
open-telemetry:mainfrom
florianl:reporter-alpha

Conversation

@florianl
Copy link
Copy Markdown
Member

@florianl florianl commented Mar 6, 2026

The merge of open-telemetry/opentelemetry-proto#733 enables the move of resource attributes from message Sample to ResourceProfiles and so being compliant with OTel.

As open-telemetry/opentelemetry-proto#733 is not officially released yet, this is work in progress.

Currently, the upstream change open-telemetry/opentelemetry-collector#14546 did not land yet.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Comment thread reporter/internal/pdata/generate.go Outdated
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl marked this pull request as ready for review March 12, 2026 13:15
@florianl florianl requested review from a team as code owners March 12, 2026 13:15
Copy link
Copy Markdown
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on this! I think some attributes got misplaced, PTAL and LMK what you think 🙇 .

Comment thread reporter/internal/pdata/generate.go
Comment thread reporter/internal/pdata/generate.go Outdated
Comment thread reporter/internal/pdata/generate.go Outdated
Comment thread reporter/base_reporter_test.go Outdated
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
reorder struct fields for better memory usage

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl requested a review from felixge March 16, 2026 10:29
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl requested a review from christos68k March 19, 2026 08:21
Copy link
Copy Markdown
Member

@Gandem Gandem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment thread reporter/internal/pdata/generate.go
Comment thread reporter/samples/samples.go
Comment thread reporter/samples/samples.go
Comment thread reporter/base_reporter.go
Comment thread reporter/samples/samples.go Outdated
Comment thread reporter/samples/samples.go Outdated
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@felixge felixge merged commit 6970788 into open-telemetry:main Mar 24, 2026
32 checks passed
gnurizen added a commit to parca-dev/opentelemetry-ebpf-profiler that referenced this pull request Apr 29, 2026
…20260429-073752

reporter: refactor for reference based attributes (open-telemetry#1234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants