Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Egui 0.18.1 is not supported by minimal-egui example (it's built with egui 0.17) #278

Closed
Roxfall opened this issue Jun 9, 2022 · 2 comments · Fixed by #281
Closed

Egui 0.18.1 is not supported by minimal-egui example (it's built with egui 0.17) #278

Roxfall opened this issue Jun 9, 2022 · 2 comments · Fixed by #281
Labels
enhancement New feature or request

Comments

@Roxfall
Copy link

Roxfall commented Jun 9, 2022 •
edited
Loading

The breaking change is egui renamed its ClippedMesh to be ClippedPrimitive in 18.0, which then messes up the render function in the example gui.rs around line 86.

I don't know the best way to reconcile these libs.

https://github.com/emilk/egui/blob/master/CHANGELOG.md
@parasyte parasyte added the enhancement New feature or request label Jun 9, 2022
@parasyte
Copy link
Owner

parasyte commented Jun 9, 2022

While not technically a blocker for that example, I do need emilk/egui#1660 (and probably emilk/egui#1684 and emilk/egui#1704) so I've been waiting for the next release before doing any more work on it. I won't reject a PR if one comes my way, though.

parasyte added a commit that referenced this issue Jun 14, 2022
@parasyte
Update egui to 0.18
ea31694 
- Closes #278
@parasyte parasyte mentioned this issue Jun 14, 2022
Merged
@parasyte
Copy link
Owner

Found some time to do the upgrade, so this should be fixed very soon.

parasyte added a commit that referenced this issue Jun 14, 2022
@parasyte
Update egui to 0.18 (#281)
af821c9 
* Update egui to 0.18

- Closes #278

* Bump MSRV to 1.60.0 for egui
JMS55 pushed a commit to JMS55/pixels that referenced this issue Jul 18, 2022
@parasyte @JMS55
Update egui to 0.18 (parasyte#281)
8335e23 
* Update egui to 0.18

- Closes parasyte#278

* Bump MSRV to 1.60.0 for egui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update egui to 0.18 parasyte/pixels
2 participants
@parasyte @Roxfall