Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egui-wgpu: Add ability to register user textures #1660

Merged
merged 1 commit into from
May 22, 2022

Conversation

flodiebold
Copy link
Contributor

It seems that with the transition from egui_wgpu_backend to egui-wgpu, the ability to register arbitrary WGPU textures as user textures got lost. I assume this wasn't intentional. This PR just adds back the functions from egui_wgpu_backend to RenderPass, though I renamed them to register_native_texture and register_native_texture_with_sampler_options.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emilk
Copy link
Owner

emilk commented May 22, 2022

This closes #1662

@emilk emilk merged commit 5d15e3d into emilk:master May 22, 2022
@flodiebold flodiebold deleted the egui-texture-from-wgpu-texture branch May 23, 2022 19:12
@flodiebold
Copy link
Contributor Author

Ah, somehow missed that one 🙂 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants