refactor: use BundleBuilder as a state builder#8861
refactor: use BundleBuilder as a state builder#8861emhane merged 18 commits intoparadigmxyz:emhane/integrate-bundle-builderfrom
BundleBuilder as a state builder#8861Conversation
| .state_original_account_info(address, present_info.into()) | ||
| .state_present_account_info(address, present_info.into()); |
There was a problem hiding this comment.
looks like setter functions that take &mut self would be useful on bundlebuilder
|
@tcoratger Just curious why this PR was created? #8264 is still up-to-date. |
|
@quentinv72 I think this was my bad... thanks for updating, I'll ensure it is properly reviewed this time... |
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
I think you can even simplify some part with the recent updates of revm, including bluealloy/revm#1527 Let me know if we can merge this or not and I have ideas of a follow up so as not to disorganize things here. |
|
blocked by #8264 |
This is an equivalent one no @mattsse? following #8264 (comment) it seems that #8264 will be staled no? |
|
I'd like to merge the other branch first, since you used it as base, so that the commits go to the author. good open source practice is to use |
Closes #4614
Acts as a follow up of #8264 after the most recent changes.
cc @mattsse