db: add setters to BundleBuilder with &mut self#1527
Merged
rakita merged 2 commits intobluealloy:mainfrom Jun 16, 2024
Merged
Conversation
mattsse
previously requested changes
Jun 16, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
having these is very useful because usually we need to call them conditionally which because slightly ugly with with the consuming builder functions.
can we also add an fn apply{_mut}<F: FnOnce(Self) -> Self>(self, f)
| } | ||
|
|
||
| /// Set address info of BundleState state. | ||
| pub fn set_state_address(&mut self, address: Address) { |
Collaborator
There was a problem hiding this comment.
since this is a builder type, we can return &mut Self on these functions so they can be chained
the existing self functions should then reuse the &mut self ones so we don't duplicate the actual impl
Contributor
Author
There was a problem hiding this comment.
Fixed, let me know if this is ok for you
rakita
approved these changes
Jun 16, 2024
This was referenced Jun 16, 2024
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related https://github.com/paradigmxyz/reth/pull/8861/files#r1641783394