refactor(transactions): move TxEip1559, TxEip1559 and TxEip4844 to separate files

[PanGan21]

Closes: #3942

[codecov]

Codecov Report

Merging #3946 (487eedd) into main (4ab924c) will decrease coverage by 0.02%.
The diff coverage is 72.62%.

Files Changed	Coverage Δ
crates/primitives/src/transaction/mod.rs	82.75% <ø> (+1.65%)	⬆️
crates/primitives/src/transaction/eip4844.rs	9.67% <9.67%> (ø)
crates/primitives/src/transaction/eip1559.rs	76.08% <76.08%> (ø)
crates/primitives/src/transaction/eip2930.rs	82.75% <82.75%> (ø)
crates/primitives/src/transaction/legacy.rs	100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	15.54% <1.67%> (-0.01%)	⬇️
unit-tests	64.55% <72.62%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	27.18% <ø> (ø)
blockchain tree	83.04% <ø> (ø)
pipeline	89.82% <ø> (ø)
storage (db)	74.29% <ø> (ø)
trie	94.70% <ø> (ø)
txpool	46.56% <ø> (-0.03%)	⬇️
networking	77.65% <ø> (-0.03%)	⬇️
rpc	58.74% <ø> (-0.01%)	⬇️
consensus	64.46% <ø> (ø)
revm	33.68% <ø> (ø)
payload builder	6.61% <ø> (ø)
primitives	87.80% <72.62%> (-0.03%)	⬇️

[mattsse]

nice,

I'd like to rename files

• legacy
• eip2930
• eip1559
• eip4844

and also move new TxEip4844 to new file

[PanGan21]

nice,

I'd like to rename files

• legacy
• eip2930
• eip1559
• eip4844

and also move new TxEip4844 to new file

Should be fixed! Thanks for the suggestions.
I am wondering if I it is better to also move the unit tests or keep them in mod.rs

[mattsse]

I am wondering if I it is better to also move the unit tests or keep them in mod.rs

very good point, let's do that as well!

we now have a smol conflict with affects the effective gas price function, and some comments

#3943

[PanGan21]

I am wondering if I it is better to also move the unit tests or keep them in mod.rs

very good point, let's do that as well!

we now have a smol conflict with affects the effective gas price function, and some comments

#3943

The refactor should be done. I kept the decode_multiple_network_txs in the same file in order to not duplicate the helper test_decode_empty_typed_tx. Let me know if something more is required!

[mattsse]

awesome, tysm for this