Conversation
mattsse
added
C-enhancement
Codecov Report
... and 8 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rkrasiuk
reviewed
Jul 27, 2023
| Some(base_fee) => { | ||
| // if the tip is greater than the max priority fee per gas, set it to the max | ||
| // priority fee per gas + base fee | ||
| let tip = self.max_fee_per_gas - base_fee as u128; |
Contributor
There was a problem hiding this comment.
is this always safe? would we mostly call this fn in blobpool after validation?
Collaborator
Author
There was a problem hiding this comment.
oh, actually no, this should be saturated sub
will fix separately, because this also affects eip1559
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add some missing functions for eip4844