feat: use tracing pool for tracing calls#3914
Merged
Conversation
8f63f26 to
5828110
Compare
Codecov Report
... and 59 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Rjected
approved these changes
Jul 26, 2023
Member
Rjected
left a comment
There was a problem hiding this comment.
LGTM, i like the docs on EthTransactions and naming that makes it clear what's spawned on the pool
6e9be16 to
2a50fba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3904
integrates the new rayon tracing pool in rpc.
simplifies trace_ and debug_: get rid of
on_blocking_task, insteadEthTransactiontrait spawns those calls.calls that spawn now begin with
spawn_to make this clear.This simplifies the interface