Skip to content

feat: use tracing pool for tracing calls#3914

Merged
mattsse merged 10 commits intomainfrom
matt/use-tracing-pool
Jul 26, 2023
Merged

feat: use tracing pool for tracing calls#3914
mattsse merged 10 commits intomainfrom
matt/use-tracing-pool

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 25, 2023

Closes #3904

integrates the new rayon tracing pool in rpc.

simplifies trace_ and debug_: get rid of on_blocking_task, instead EthTransaction trait spawns those calls.

calls that spawn now begin with spawn_ to make this clear.

This simplifies the interface

@mattsse mattsse requested review from Rjected and gakonst as code owners July 25, 2023 17:32
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation labels Jul 25, 2023
@mattsse mattsse force-pushed the matt/use-tracing-pool branch from 8f63f26 to 5828110 Compare July 25, 2023 17:37
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #3914 (2a50fba) into main (8cdb097) will decrease coverage by 1.35%.
The diff coverage is 21.22%.

Impacted file tree graph

Files Changed Coverage Δ
crates/rpc/rpc-builder/src/auth.rs 44.16% <0.00%> (-0.23%) ⬇️
crates/rpc/rpc-builder/src/eth.rs 70.96% <ø> (ø)
crates/rpc/rpc/src/debug.rs 11.77% <0.00%> (+0.88%) ⬆️
crates/rpc/rpc/src/trace.rs 5.70% <0.00%> (-37.36%) ⬇️
crates/rpc/rpc/src/tracing_call.rs 69.44% <40.00%> (ø)
crates/rpc/rpc/src/eth/api/transactions.rs 21.68% <42.85%> (-6.00%) ⬇️
crates/rpc/rpc-builder/src/lib.rs 63.91% <76.92%> (-1.57%) ⬇️
crates/rpc/rpc/src/eth/api/mod.rs 61.30% <100.00%> (+0.28%) ⬆️
crates/rpc/rpc/src/eth/api/server.rs 93.85% <100.00%> (+0.01%) ⬆️
crates/rpc/rpc/src/eth/api/state.rs 50.39% <100.00%> (+0.79%) ⬆️

... and 59 files with indirect coverage changes

Flag Coverage Δ
integration-tests 12.97% <18.39%> (-2.58%) ⬇️
unit-tests 64.52% <3.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.24% <ø> (ø)
blockchain tree 83.01% <ø> (ø)
pipeline 89.68% <ø> (ø)
storage (db) 73.22% <ø> (-0.98%) ⬇️
trie 94.70% <ø> (ø)
txpool 46.56% <ø> (ø)
networking 74.21% <ø> (-3.68%) ⬇️
rpc 56.75% <21.22%> (-1.84%) ⬇️
consensus 64.46% <ø> (ø)
revm 33.68% <ø> (ø)
payload builder 6.61% <ø> (ø)
primitives 86.96% <ø> (-1.12%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i like the docs on EthTransactions and naming that makes it clear what's spawned on the pool

@mattsse mattsse enabled auto-merge July 26, 2023 16:09
@mattsse mattsse added this pull request to the merge queue Jul 26, 2023
@mattsse mattsse removed this pull request from the merge queue due to a manual request Jul 26, 2023
@mattsse mattsse enabled auto-merge July 26, 2023 16:23
@mattsse mattsse force-pushed the matt/use-tracing-pool branch from 6e9be16 to 2a50fba Compare July 26, 2023 16:24
@mattsse mattsse added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 49e1127 Jul 26, 2023
@mattsse mattsse deleted the matt/use-tracing-pool branch July 26, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a dedicated threadpool for tracing rpc requests

2 participants