WIP: Implement prestateTracer#3923
Merged
mattsse merged 6 commits intoparadigmxyz:mainfrom Jul 28, 2023
Merged
Conversation
mattsse
requested changes
Jul 26, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this looks pretty good already.
the rpc impls is ready, the tracing logic needs a few changes
onbjerg
added
C-enhancement
PlamenHristov
requested review from
gakonst,
joshieDo,
onbjerg,
rakita,
rkrasiuk and
shekhirin
as code owners
PlamenHristov
force-pushed
the
plamen/feature-prestate-tracer
branch
from
a3eb399 to
7fb836e
Compare
Contributor
Author
|
@mattsse, let me know if that looks better. |
PlamenHristov
force-pushed
the
plamen/feature-prestate-tracer
branch
from
7fb836e to
87cee89
Compare
Contributor
Author
|
@mattsse , should be good now. |
Codecov Report
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following is a WIP for prestatTracer. With regard to that there are a couple of things that I'd ask for help
fn trace_transaction()given that it won't be satisfied byDatabaseRef.1.1. Should the signature of
geth_prestate_traces()be changed to accept a mutable reference and then borrow mutably frominspect_call_at_and_return_state()that gets called intry_debug_trace_call()?1.2. Or maybe make a copy of the db object?
Closes #2624