refactor(storage): historical state lookup (better comments)#3867
Merged
mattsse merged 4 commits intoparadigmxyz:mainfrom Jul 27, 2023
Merged
refactor(storage): historical state lookup (better comments)#3867mattsse merged 4 commits intoparadigmxyz:mainfrom
mattsse merged 4 commits intoparadigmxyz:mainfrom
Conversation
onbjerg
added
C-debt
shekhirin
approved these changes
Jul 24, 2023
Member
shekhirin
left a comment
shekhirin
left a comment
There was a problem hiding this comment.
LGTM, thank you for improving the comments!
Member
|
@mattsse PTAL 👀 |
mattsse
approved these changes
Jul 27, 2023
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
I like this, tysm.
sorry for the delay
Codecov Report
... and 8 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is version of #3806 with improved comments. I have also renamed the
NotWrittenenum variant toNotYetWrittenwhich is slightly clearer.