refactor(storage): historical state lookup

[shekhirin]

Refactor changes from #2966 into one generic function and add comments to explain the behaviour.

[codecov]

Codecov Report

Merging #3806 (4110974) into main (9a00f04) will decrease coverage by 0.07%.
The diff coverage is 53.24%.

Impacted Files	Coverage Δ
bin/reth/src/stage/drop.rs	2.00% <0.00%> (-0.13%)	⬇️
crates/primitives/src/transaction/access_list.rs	53.84% <0.00%> (-23.94%)	⬇️
crates/primitives/src/withdrawal.rs	82.35% <0.00%> (-17.65%)	⬇️
crates/stages/src/metrics/listener.rs	0.00% <0.00%> (ø)
crates/transaction-pool/src/lib.rs	32.31% <0.00%> (-1.23%)	⬇️
crates/transaction-pool/src/noop.rs	11.02% <0.00%> (-0.51%)	⬇️
crates/transaction-pool/src/ordering.rs	0.00% <0.00%> (ø)
crates/transaction-pool/src/pool/best.rs	75.00% <0.00%> (-14.56%)	⬇️
crates/transaction-pool/src/pool/mod.rs	41.00% <0.00%> (-0.87%)	⬇️
crates/transaction-pool/src/pool/pending.rs	75.87% <0.00%> (-9.44%)	⬇️
... and 16 more

... and 7 files with indirect coverage changes

Flag	Coverage Δ
integration-tests	15.70% <0.00%> (-0.06%)	⬇️
unit-tests	64.14% <53.24%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
reth binary	26.29% <25.00%> (-0.04%)	⬇️
blockchain tree	83.02% <ø> (ø)
pipeline	87.04% <78.57%> (-0.10%)	⬇️
storage (db)	74.31% <100.00%> (+0.02%)	⬆️
trie	94.65% <ø> (ø)
txpool	47.43% <8.13%> (-0.41%)	⬇️
networking	77.70% <100.00%> (-0.01%)	⬇️
rpc	58.32% <ø> (-0.03%)	⬇️
consensus	64.96% <ø> (ø)
revm	33.76% <ø> (ø)
payload builder	6.61% <ø> (ø)
primitives	88.04% <65.04%> (-0.29%)	⬇️

[joshieDo]

clean, appreciate the explanations

[shekhirin]

@petertdavies would appreciate a look at the comments

[shekhirin]

Closed in favor of #3867