Skip to content

fix(net): track block access list requests in eth request metrics #23880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 2 commits into from
May 29, 2026
Merged

fix(net): track block access list requests in eth request metrics #23880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5956c43
fix(net): track block access list requests in eth request metrics
RandoomWalks Apr 30, 2026
ae06136
Merge branch 'main' into fix/bal-request-metric
mattsse May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/net/network/src/eth_requests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ where
mut request: GetBlockAccessLists,
response: oneshot::Sender<RequestResult<BlockAccessLists>>,
) {
self.metrics.eth_block_access_lists_requests_received_total.increment(1);
request.0.truncate(MAX_BLOCK_ACCESS_LISTS_SERVE);

let limit = GetBlockAccessListLimit::ResponseSizeSoftLimit(SOFT_RESPONSE_LIMIT);
Expand Down
3 changes: 3 additions & 0 deletions crates/net/network/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,9 @@ pub struct EthRequestHandlerMetrics {
/// Number of `GetNodeData` requests received
pub(crate) eth_node_data_requests_received_total: Counter,

/// Number of `GetBlockAccessLists` requests received
pub(crate) eth_block_access_lists_requests_received_total: Counter,

/// Duration in seconds of call to poll
/// [`EthRequestHandler`](crate::eth_requests::EthRequestHandler).
pub(crate) acc_duration_poll_eth_req_handler: Gauge,
Expand Down
Loading