fix(net): track block access list requests in eth request metrics#23880
Merged
Conversation
Mirrors the metric pattern used for headers, bodies, receipts, and node data requests on this code path. Adds eth_block_access_lists_requests_received_total Counter and increments it on each on_block_access_lists_request invocation. Follow-up to paradigmxyz#23754 (count cap) and paradigmxyz#23725 (response size limit).
github-actions
Bot
added
the
S-stale
mattsse
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
eth_block_access_lists_requests_received_totalCounter, mirroring the existingeth_<type>_requests_received_totalfamily inEthRequestHandlerMetrics. Increments on eachon_block_access_lists_requestinvocation, matching the pattern used by sibling handlers.The bundled overview dashboard (
etc/grafana/dashboards/overview.json) already graphs the sibling counters; a BAL panel can land in a follow-up once this metric exists.Follow-up to #23754 and #23725.