feat: transition from &mut State<DB> -> StateDB#22098
Closed
0xForerunner wants to merge 8 commits intoparadigmxyz:mainfrom
Closed
feat: transition from &mut State<DB> -> StateDB#220980xForerunner wants to merge 8 commits intoparadigmxyz:mainfrom
0xForerunner wants to merge 8 commits intoparadigmxyz:mainfrom
Conversation
0xForerunner
requested review from
Rjected,
gakonst,
klkvr and
mattsse
as code owners
3 tasks
Collaborator
|
Hey! We're doing some spring cleaning on our PR backlog 🧹 Closing old PRs to keep things tidy. If this is still relevant, please feel free to re-open — we appreciate your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves reth traits from using the concrete State to relying on a new StateDB trait. This allows trait implementations to be much more flexible, and allows for greater code reuse.
In particular, we're implementing Flashblock based block access lists, and we need a DB wrapper around State that can construct the access lists. This will allow us to build something like BalBuilderDB<&mut State>, and then impl StateDB for this type.
This PR should not yet be merged since it depends on these upstream PRs.
alloy-rs/evm#238 (open)
bluealloy/revm#3205 (merged)