feat: Clean up StateDB methods, bump revm#238
Open
0xForerunner wants to merge 2 commits intoalloy-rs:mainfrom
Open
feat: Clean up StateDB methods, bump revm#2380xForerunner wants to merge 2 commits intoalloy-rs:mainfrom
0xForerunner wants to merge 2 commits intoalloy-rs:mainfrom
Conversation
0xForerunner
force-pushed
the
state-db-methods
branch
from
bb14179 to
0833666
Compare
Contributor
Author
Contributor
Author
Member
|
iiuc those changes are needed just to make |
Contributor
Author
|
@klkvr We need the extra trait methods for this PR into reth. The ultimate reason is for block access lists. We have a BAL implementation which requires the use of a wrapper type around State. This isn't possible without these methods. |
0xForerunner
force-pushed
the
state-db-methods
branch
from
f2b555d to
3e5e8f3
Compare
Contributor
Author
|
@klkvr just rebased on main. Should be good to go! |
Member
|
@0xForerunner it's still not obvious to me why we need those methods to be honest. does your BAL implementation require the block builder to hold your custom database? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary methods from
StateDBin favour of usingDatabaseCommitExt. See #234 and this pr for more details.Additionally we've added a few more trait methods to abstract away from
revm::State.You can see why this is required by taking a look at this pr into reth.
PR Checklist