fix: set StaticFileArgs defaults for edge#21208
Merged
Conversation
joshieDo
requested review from
Rjected,
klkvr,
mattsse,
rakita and
shekhirin
as code owners
joshieDo
force-pushed
the
joshie/edge-sf-args
branch
2 times, most recently
from
03e0f99 to
b8d02e4
Compare
yongkangc
approved these changes
Jan 20, 2026
joshieDo
added
A-db
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
joshieDo
force-pushed
the
joshie/edge-sf-args
branch
from
b8d02e4 to
41baad4
Compare
gakonst
added a commit
that referenced
this pull request
Jan 20, 2026
…ocksDB flags - Remove StaticFilesArgs::to_settings() method as it's superseded by NodeConfig::storage_settings() which handles both static files and RocksDB - Add edge feature behavior to RocksDbArgs flags, matching the pattern from #21208 - Individual flags now default to true when 'edge' feature is enabled - Changed flags from Option<bool> to bool with proper defaults - Add RocksDbArgs to EnvironmentArgs in cli/commands for consistent storage settings - Update all callers to use storage_settings() instead of static_files.to_settings() Closes comment from #21191 (PR discussion r2709676364)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to start the node with edge features