feat(cli): add --rocksdb.* flags for RocksDB table routing by yongkangc · Pull Request #21191 · paradigmxyz/reth

yongkangc · 2026-01-19T14:56:51Z

Summary

Introduces RocksDbArgs struct with dedicated --rocksdb.* prefix for RocksDB table routing.

Flags

--rocksdb.tx-hash - Route tx hash -> number table to RocksDB
--rocksdb.storages-history - Route storages history to RocksDB
--rocksdb.account-history - Route account history to RocksDB

All flags are genesis-initialization-only (changing later requires re-sync).

PR Stack

closes #20393

Introduces RocksDbArgs struct with --rocksdb.tx-hash, --rocksdb.storages-history, and --rocksdb.account-history flags for controlling which tables route to RocksDB. These flags are genesis-initialization-only (changing later requires re-sync).

- Add test for bare flag without value (should require a value) - Add test for space-separated value syntax

codspeed-hq · 2026-01-19T15:08:48Z

Merging this PR will not alter performance

✅ 118 untouched benchmarks
⏩ 7 skipped benchmarks¹

_{Comparing feat/rocksdb-cli-v2 (0d8219f) with main (3ba3708)}

7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

- Add rocksdb field to NodeConfig - Update init_genesis to apply RocksDB settings on top of static files settings - All struct initializers and Clone impl updated

Wire RocksDbArgs through NodeCommand to enable CLI flags to be passed through to NodeConfig. Also fix clippy warnings for doc_markdown (backticks around RocksDB) and missing_const_for_fn.

Consolidate 12 tests down to 3 essential ones covering defaults, parsing, and settings application.

- If any --rocksdb.* flag is set to true, all RocksDB tables are enabled - Explicit --rocksdb.<table>=false overrides can disable specific tables - Logs startup message when grouped behavior triggers - DRY'd doc comments (genesis-only note moved to struct level) - Added comprehensive tests for grouped enable behavior

- Add test for all-explicit-false edge case - Add test verifying non-rocksdb fields preserved - Rename parameter defaults -> settings for clarity - Extract storage_settings_with_logging() helper to DRY up with_genesis/init_genesis - Fix clippy doc warnings (backticks around RocksDB)

…ging

yongkangc · 2026-01-20T09:24:27Z

crates/node/core/src/args/rocksdb.rs

+        args: T,
+    }
+
+    #[test]


default is None

crates/node/builder/src/launch/common.rs

Encapsulates the storage settings derivation logic that combines static_files.to_settings() with rocksdb.apply_to_settings() into a single method, as suggested in PR review.

yongkangc · 2026-01-20T10:35:55Z

@joshieDo refactored into the function storage_settings() based on your comment

crates/node/core/src/node_config.rs

crates/node/core/src/args/rocksdb.rs

- Add StorageSettings::merge() to combine settings - Change RocksDbArgs::apply_to_settings() to to_settings() - Update NodeConfig::storage_settings() to use the cleaner pattern: self.static_files.to_settings().merge(self.rocksdb.to_settings())

…c nits

joshieDo · 2026-01-20T18:54:37Z

crates/node/core/src/node_config.rs

    }

+    /// Returns the effective storage settings derived from static-file and `RocksDB` CLI args.
+    pub fn storage_settings(&self) -> StorageSettings {


we can do it in this PR or on a follow-up, but we probably want to remove static_files.to_settings() i think ?

and we should make sure that the following behaviour introduced here
https://github.com/paradigmxyz/reth/pull/21208/files also applies to rocksdb

makes sense, think we might want to do it in a separate pr - will be on this

…ocksDB flags - Remove StaticFilesArgs::to_settings() method as it's superseded by NodeConfig::storage_settings() which handles both static files and RocksDB - Add edge feature behavior to RocksDbArgs flags, matching the pattern from #21208 - Individual flags now default to true when 'edge' feature is enabled - Changed flags from Option<bool> to bool with proper defaults - Add RocksDbArgs to EnvironmentArgs in cli/commands for consistent storage settings - Update all callers to use storage_settings() instead of static_files.to_settings() Closes comment from #21191 (PR discussion r2709676364)

Rjected

lgtm

…ocksDB flags This PR addresses the review comment from #21191: - Remove `StaticFilesArgs::to_settings()` - superseded by `NodeConfig::storage_settings()` - Add edge feature behavior to RocksDB flags - flags default to `true` when `edge` feature is enabled - Add `RocksDbArgs` to `EnvironmentArgs` with `storage_settings()` method - Update `storage_settings()` to use `StorageSettings::edge()` or `StorageSettings::legacy()` base - Replace `static_files.to_settings()` calls with `storage_settings()` in launch/common.rs

github-project-automation bot added this to Reth Tracker Jan 19, 2026

github-project-automation bot moved this to Backlog in Reth Tracker Jan 19, 2026

yongkangc mentioned this pull request Jan 19, 2026

feat(storage): add startup validation for RocksDB CLI flags #21192

Closed

fix: add edge case tests for RocksDB CLI flags

5166a6c

- Add test for bare flag without value (should require a value) - Add test for space-separated value syntax

feat: integrate RocksDbArgs into NodeConfig and launch code

cfa9a4a

- Add rocksdb field to NodeConfig - Update init_genesis to apply RocksDB settings on top of static files settings - All struct initializers and Clone impl updated

yongkangc force-pushed the feat/rocksdb-cli-v2 branch from fc5746f to cfa9a4a Compare January 19, 2026 15:17

yongkangc self-assigned this Jan 19, 2026

yongkangc added A-db Related to the database A-cli Related to the reth CLI A-rocksdb Related to rocksdb integration labels Jan 19, 2026

yongkangc requested review from Rjected and fgimenez January 19, 2026 17:41

fix: add rocksdb field to NodeCommand and fix clippy warnings

bf13a52

Wire RocksDbArgs through NodeCommand to enable CLI flags to be passed through to NodeConfig. Also fix clippy warnings for doc_markdown (backticks around RocksDB) and missing_const_for_fn.

yongkangc requested a review from joshieDo January 19, 2026 17:46

docs: regenerate CLI documentation for --rocksdb.* flags

1aad483

yongkangc marked this pull request as ready for review January 19, 2026 18:01

yongkangc requested review from gakonst, klkvr and mattsse as code owners January 19, 2026 18:01

yongkangc added 5 commits January 19, 2026 22:15

refactor: simplify RocksDbArgs tests

df237b9

Consolidate 12 tests down to 3 essential ones covering defaults, parsing, and settings application.

fix: log actual enabled tables instead of 'all tables'

5f8dd4b

refactor: remove helper function, inline rocksdb settings without log…

3905e31

…ging

yongkangc commented Jan 20, 2026

View reviewed changes

crates/node/core/src/args/rocksdb.rs

args: T,

}

#[test]

Copy link
Copy Markdown

Member Author

yongkangc Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is None

chore: regenerate CLI docs for RocksDB flags

09cc552

joshieDo reviewed Jan 20, 2026

View reviewed changes

crates/node/builder/src/launch/common.rs Outdated Show resolved Hide resolved

refactor: add NodeConfig::storage_settings() method

662684a

Encapsulates the storage settings derivation logic that combines static_files.to_settings() with rocksdb.apply_to_settings() into a single method, as suggested in PR review.

yongkangc enabled auto-merge January 20, 2026 12:04

joshieDo reviewed Jan 20, 2026

View reviewed changes

crates/node/core/src/node_config.rs Outdated Show resolved Hide resolved

yongkangc requested a review from rakita as a code owner January 20, 2026 14:56

Rjected reviewed Jan 20, 2026

View reviewed changes

crates/node/core/src/args/rocksdb.rs Outdated Show resolved Hide resolved

yongkangc force-pushed the feat/rocksdb-cli-v2 branch from b26d54d to 8ebf7fc Compare January 20, 2026 17:43

yongkangc force-pushed the feat/rocksdb-cli-v2 branch from 8ebf7fc to 3972cd0 Compare January 20, 2026 17:48

yongkangc added 5 commits January 20, 2026 17:55

fix: call RocksDbArgs::validate() before building NodeConfig

8e64a3f

fix: add backticks to RocksDB in doc comments for clippy

c1a323f

refactor: build StorageSettings directly instead of using merge()

ee64133

fix: revert init_genesis to use static_files.to_settings() and fix do…

dcb9691

…c nits

docs: update CLI docs for rocksdb help text formatting

0d8219f

joshieDo reviewed Jan 20, 2026

View reviewed changes

yongkangc requested review from Rjected and joshieDo January 20, 2026 19:06

gakonst mentioned this pull request Jan 20, 2026

refactor: remove static_files.to_settings() and add edge feature to RocksDB flags #21225

Merged

Rjected approved these changes Jan 20, 2026

View reviewed changes

yongkangc added this pull request to the merge queue Jan 20, 2026

github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Jan 20, 2026

Merged via the queue into main with commit bc79cc4 Jan 20, 2026
45 checks passed

yongkangc deleted the feat/rocksdb-cli-v2 branch January 20, 2026 19:40

github-project-automation bot moved this from In Progress to Done in Reth Tracker Jan 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli): add --rocksdb.* flags for RocksDB table routing#21191

feat(cli): add --rocksdb.* flags for RocksDB table routing#21191
yongkangc merged 20 commits intomainfrom
feat/rocksdb-cli-v2

yongkangc commented Jan 19, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jan 19, 2026 •

edited

Loading

Uh oh!

yongkangc Jan 20, 2026

Uh oh!

Uh oh!

yongkangc commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

joshieDo Jan 20, 2026

Uh oh!

yongkangc Jan 20, 2026

Uh oh!

Rjected left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

yongkangc commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Flags

PR Stack

Uh oh!

codspeed-hq bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

yongkangc Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yongkangc commented Jan 20, 2026

Uh oh!

Uh oh!

Uh oh!

joshieDo Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

yongkangc Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Rjected left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yongkangc commented Jan 19, 2026 •

edited

Loading

codspeed-hq bot commented Jan 19, 2026 •

edited

Loading