Skip to content

feat: update metrics on save_blocks#21045

Merged
joshieDo merged 1 commit intojoshie/par-save-blocks-acc-csfrom
joshie/par-save-metrics
Jan 14, 2026
Merged

feat: update metrics on save_blocks#21045
joshieDo merged 1 commit intojoshie/par-save-blocks-acc-csfrom
joshie/par-save-metrics

Conversation

@joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Jan 14, 2026

Adds metrics for save_blocks and commit operations.


PR Stack

#21045 (metrics) ◀  #21003 (rocksdb)
         \           /
          \         /
           #21012 (account changesets)
              ↓
           #20993 (parallelize save_blocks)
              ↓
            main

@joshieDo joshieDo self-assigned this Jan 14, 2026
@joshieDo joshieDo added A-db Related to the database A-observability Related to tracing, metrics, logs and other observability tools A-static-files Related to static files labels Jan 14, 2026
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Jan 14, 2026
@joshieDo joshieDo marked this pull request as ready for review January 14, 2026 16:41
@joshieDo joshieDo force-pushed the joshie/par-save-metrics branch 2 times, most recently from 51bde4e to 5527bd1 Compare January 14, 2026 16:54
@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Jan 14, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 14, 2026

Merging this PR will not alter performance

✅ 118 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing joshie/par-save-metrics (337d14d) with joshie/par-save-blocks-acc-cs (e7cf1f8)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@joshieDo joshieDo force-pushed the joshie/par-save-metrics branch from 5527bd1 to 337d14d Compare January 14, 2026 17:22
@joshieDo joshieDo merged commit bed465e into joshie/par-save-blocks-acc-cs Jan 14, 2026
40 checks passed
@joshieDo joshieDo deleted the joshie/par-save-metrics branch January 14, 2026 17:39
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-db Related to the database A-observability Related to tracing, metrics, logs and other observability tools A-static-files Related to static files

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants