Skip to content

feat: add rocksdb to save_blocks#21003

Merged
joshieDo merged 18 commits intomainfrom
joshie/par-save-blocks-rocksdb
Jan 15, 2026
Merged

feat: add rocksdb to save_blocks#21003
joshieDo merged 18 commits intomainfrom
joshie/par-save-blocks-rocksdb

Conversation

@joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Jan 13, 2026 •
edited
Loading

  • spawn thread for rocksdb writer
  • remove unused stub methods

PR Stack

#21045 (metrics)    #21003 (rocksdb) ◀
         \           /
          \         /
           #21012 (account changesets)
              ↓
           #20993 (parallelize save_blocks)
              ↓
            main

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Jan 13, 2026
@joshieDo joshieDo self-assigned this Jan 13, 2026
@joshieDo joshieDo added the A-rocksdb Related to rocksdb integration label Jan 13, 2026
@joshieDo joshieDo force-pushed the joshie/par-save-blocks branch from 868f884 to b271a28 Compare January 13, 2026 16:15
@joshieDo joshieDo force-pushed the joshie/par-save-blocks-rocksdb branch from a2def32 to b958ea9 Compare January 13, 2026 16:16
@joshieDo joshieDo force-pushed the joshie/par-save-blocks branch 5 times, most recently from 705619b to c38dbb8 Compare January 13, 2026 16:46
@joshieDo joshieDo force-pushed the joshie/par-save-blocks-rocksdb branch from b958ea9 to 408bc9a Compare January 13, 2026 16:47
@joshieDo joshieDo force-pushed the joshie/par-save-blocks branch from c38dbb8 to ee9c144 Compare January 13, 2026 16:48
@joshieDo joshieDo force-pushed the joshie/par-save-blocks-rocksdb branch from 408bc9a to 84daf91 Compare January 13, 2026 16:48
@joshieDo joshieDo force-pushed the joshie/par-save-blocks branch 3 times, most recently from 79cf709 to ac60f5f Compare January 13, 2026 17:35
@joshieDo joshieDo force-pushed the joshie/par-save-blocks branch from ac60f5f to 40ea593 Compare January 13, 2026 17:47
@joshieDo joshieDo force-pushed the joshie/par-save-blocks-rocksdb branch from 84daf91 to 7443ed9 Compare January 13, 2026 17:49
@joshieDo joshieDo changed the base branch from joshie/par-save-blocks to joshie/par-save-blocks-acc-cs January 13, 2026 18:31
@joshieDo joshieDo force-pushed the joshie/par-save-blocks-acc-cs branch from 5502a2b to e7cf1f8 Compare January 13, 2026 18:33
@joshieDo joshieDo force-pushed the joshie/par-save-blocks-rocksdb branch from 7443ed9 to 6ccea8d Compare January 13, 2026 18:42
This was referenced Jan 14, 2026
Merged
Merged
Merged
@joshieDo joshieDo force-pushed the joshie/par-save-blocks-rocksdb branch from fff917c to d8a600c Compare January 14, 2026 21:38
@yongkangc yongkangc mentioned this pull request Jan 14, 2026
Closed
@joshieDo joshieDo force-pushed the joshie/par-save-blocks-rocksdb branch from a795126 to 8e8e6b7 Compare January 15, 2026 12:31
Base automatically changed from joshie/par-save-blocks to main January 15, 2026 15:17
@yongkangc yongkangc marked this pull request as ready for review January 15, 2026 17:07
@yongkangc yongkangc self-requested a review January 15, 2026 17:47
@joshieDo joshieDo enabled auto-merge January 15, 2026 18:00
yongkangc
yongkangc reviewed Jan 15, 2026
View reviewed changes
crates/storage/provider/src/providers/database/provider.rs
.field("storage", &self.storage)
.field("storage_settings", &self.storage_settings)
.field("rocksdb_provider", &self.rocksdb_provider);
#[cfg(all(unix, feature = "rocksdb"))]
Copy link
Member

@yongkangc yongkangc Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this?

yongkangc
yongkangc reviewed Jan 15, 2026
View reviewed changes
crates/storage/provider/src/providers/database/provider.rs
storage,
storage_settings,
rocksdb_provider,
#[cfg(all(unix, feature = "rocksdb"))]
Copy link
Member

@yongkangc yongkangc Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this feature?

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Jan 15, 2026
@joshieDo joshieDo added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit e9b079a Jan 15, 2026
43 of 46 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Jan 15, 2026
@joshieDo joshieDo deleted the joshie/par-save-blocks-rocksdb branch January 15, 2026 18:44
yongkangc added a commit that referenced this pull request Jan 15, 2026
@joshieDo @pepyakin @yongkangc
feat: add rocksdb to save_blocks (#21003)
b9e15db 
Co-authored-by: Sergei Shulepov <s.pepyakin@gmail.com>
Co-authored-by: Sergei Shulepov <pep@tempo.xyz>
Co-authored-by: yongkangc <chiayongkang@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yongkangc yongkangc yongkangc approved these changes

@rakita rakita Awaiting requested review from rakita

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees

@joshieDo joshieDo

Labels

A-rocksdb Related to rocksdb integration

Projects

Reth Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshieDo @yongkangc @pepyakin