perf(storage): flatten TrieUpdates before persist#20785
Closed
cwkang1998 wants to merge 1 commit intoparadigmxyz:mainfrom
Closed
perf(storage): flatten TrieUpdates before persist#20785cwkang1998 wants to merge 1 commit intoparadigmxyz:mainfrom
cwkang1998 wants to merge 1 commit intoparadigmxyz:mainfrom
Conversation
cwkang1998
force-pushed
the
perf/flatten-trieupdates-before-persists
branch
2 times, most recently
from
b28d22e to
f03ef4b
Compare
cwkang1998
requested review from
joshieDo,
rakita and
shekhirin
as code owners
cwkang1998
force-pushed
the
perf/flatten-trieupdates-before-persists
branch
3 times, most recently
from
8c930f0 to
ff12a70
Compare
mattsse
added
C-perf
Member
mediocregopher
left a comment
mediocregopher
left a comment
There was a problem hiding this comment.
This looks correct to me, just needs merge conflict fixed. I'll also want to test this very thoroughly on real nodes before merging, as this area caused us problems in the past.
Contributor
Author
Got it, let me fix the merge conflicts. I'll try to test this on real nodes as well and report back in a day or 2. |
Accumulates TriesUpdateSorted and batch write at at the end. Prior benchmark done in paradigmxyz#19739 indicates this should improve batch processing performance. Both paradigmxyz#19739 and its succeesor paradigmxyz#19991, contains benchmarks that measures the performance improvements. I am not really familiar on how to do that, so if that's something that's required, would appreciate some help. Closes paradigmxyz#20611
cwkang1998
force-pushed
the
perf/flatten-trieupdates-before-persists
branch
from
ff12a70 to
43f9d52
Compare
Contributor
Author
|
Closing this as it seems to be completed by #21142. If I am wrong feel free to reopen and I shall resume work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accumulates TriesUpdateSorted and batch write at at the end. Prior benchmark done in #19739 indicates this should improve batch processing performance.
Both #19739 and its succeesor #19991,, contains benchmarks that measures the performance improvements. I am not really familiar on how to do that, so if that's something that's required, would appreciate some guidance.
Closes #20611