fix(mev): correct refund calculation in sim_bundle#19991
Merged
mattsse merged 1 commit intoparadigmxyz:mainfrom Nov 28, 2025
Merged
fix(mev): correct refund calculation in sim_bundle#19991mattsse merged 1 commit intoparadigmxyz:mainfrom
mattsse merged 1 commit intoparadigmxyz:mainfrom
Conversation
zeroprooff
requested review from
Rjected,
RomanHodulak and
mattsse
as code owners
mattsse
approved these changes
Nov 28, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
ah I see, this would always decrease the paylout value
mattsse
added
C-bug
cwkang1998
added a commit
to cwkang1998/reth
that referenced
this pull request
Jan 8, 2026
Accumulates TriesUpdateSorted and batch write at at the end. Prior benchmark done in paradigmxyz#19739 indicates this should improve batch processing performance. Both paradigmxyz#19739 and its succeesor paradigmxyz#19991, contains benchmarks that measures the performance improvements. I am not really familiar on how to do that, so if that's something that's required, would appreciate some help. Closes paradigmxyz#20611
cwkang1998
added a commit
to cwkang1998/reth
that referenced
this pull request
Jan 8, 2026
Accumulates TriesUpdateSorted and batch write at at the end. Prior benchmark done in paradigmxyz#19739 indicates this should improve batch processing performance. Both paradigmxyz#19739 and its succeesor paradigmxyz#19991, contains benchmarks that measures the performance improvements. I am not really familiar on how to do that, so if that's something that's required, would appreciate some help. Closes paradigmxyz#20611
cwkang1998
added a commit
to cwkang1998/reth
that referenced
this pull request
Jan 9, 2026
Accumulates TriesUpdateSorted and batch write at at the end. Prior benchmark done in paradigmxyz#19739 indicates this should improve batch processing performance. Both paradigmxyz#19739 and its succeesor paradigmxyz#19991, contains benchmarks that measures the performance improvements. I am not really familiar on how to do that, so if that's something that's required, would appreciate some help. Closes paradigmxyz#20611
cwkang1998
added a commit
to cwkang1998/reth
that referenced
this pull request
Jan 13, 2026
Accumulates TriesUpdateSorted and batch write at at the end. Prior benchmark done in paradigmxyz#19739 indicates this should improve batch processing performance. Both paradigmxyz#19739 and its succeesor paradigmxyz#19991, contains benchmarks that measures the performance improvements. I am not really familiar on how to do that, so if that's something that's required, would appreciate some help. Closes paradigmxyz#20611
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where multiple transactions with refund_percent in a bundle were getting incorrect refund amounts.
The problem was that each transaction calculated its refund from the already-reduced refundable_value instead of the original amount. This caused later transactions to receive progressively smaller payouts.
For example, with two txs requesting 50% refund each from 1000 wei:
The fix stores the original refundable_value before the loop and uses that for all calculations. This matches the validation logic that ensures the sum of all refund percentages doesn't exceed 100%.