fix: ensure receipt consistency check is done over block number#19723
Merged
fix: ensure receipt consistency check is done over block number#19723
Conversation
joshieDo
changed the title
joshieDo
added
A-staged-sync
mattsse
approved these changes
Nov 13, 2025
Comment on lines
+212
to
+215
| // Get highest block number in static files for receipts | ||
| let static_file_block_num = static_file_provider | ||
| .get_highest_static_file_block(StaticFileSegment::Receipts) | ||
| .unwrap_or(0); |
shekhirin
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #19399, we might not write receipts on a static file during pipeline sync, even though we are incrementing the segment block number.
This lead to failing the second run of
ExecutionStage::ensure_consistency, since the consistency check was being done overTxNumberinstead ofBlockNumber.