feat(provider, prune): return receipts log filter by shekhirin · Pull Request #19630 · paradigmxyz/reth

shekhirin · 2025-11-10T13:51:48Z

Fixes #19621

This PR returns the previously removed receipts log filter pruning, but makes it work only with Full and Before prune modes. Most of the changes are reverted from #19184.

We're returning it, because some stakers depend on having receipts from certain staking protocols, and they don't want to store all 300GB+ of receipts on Mainnet.

We don't have Distance prune mode for this segment anymore because it's not useful for the type of pruning stakers do, and for us to support it, we would need to add a prune segment back. Full and Before modes work without a separate pruning segment, writing only specific receipts at the time of persisting.

codspeed-hq · 2025-11-10T13:59:37Z

CodSpeed Performance Report

Merging #19630 will improve performances by 33.22%

_{Comparing alexey/receipts-log-filter-is-back (d5fc327) with main (4621456)}

Summary

⚡ 1 improvement
✅ 80 untouched

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`remove_leaf[1000]`	270.2 µs	202.8 µs	+33.22%

…ilter-is-back

mattsse

a few nits

definitely need @joshieDo to review as well and need to take a look at the previous pr

mattsse · 2025-11-10T23:01:39Z

crates/storage/provider/src/either_writer.rs

+#[derive(Debug, EnumIs)]
+#[allow(missing_docs)]
+pub enum EitherWriterDestination {
+    Database,
+    StaticFile,
+}


this type is out of order

mattsse · 2025-11-10T23:03:17Z

crates/storage/provider/src/either_writer.rs

+}
+
+impl EitherWriter<'_, (), ()> {
+    /// Returns the destination for writing receipts.


this needs docs about what the rules are here

mattsse · 2025-11-10T23:06:02Z

crates/prune/types/src/segment.rs

    #[error("the configuration provided for {0} is invalid")]
    Configuration(PruneSegment),
+    /// Unsupported receipts log filter prune mode for address.
+    #[error("distance prune mode is not supported for receipts log filter, check address {0}")]


what should be checked here with the address?

mattsse · 2025-11-10T23:07:04Z

crates/prune/types/src/lib.rs

is this what we had previously?

can we reference the previous pr in the pr description?

crates/prune/types/src/target.rs

Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com>

joshieDo · 2025-11-10T23:27:35Z

crates/prune/prune/src/segments/set.rs

@@ -84,2 +83,2 @@
            .segment_opt(receipts.map(UserReceipts::new))


do we no longer need the following?

// Receipts by logs .segment_opt( (!receipts_log_filter.is_empty()) .then(|| ReceiptsByLogs::new(receipts_log_filter.clone())), )

nope, because we don't have a prune segment anymore! Pruning for receipts log filter is now handled at the time of writing.

dont we follow the MINIMUM_PRUNING_DISTANCE "rule", so we do need the pruner to remove the other receipts once its out of that range no?

crates/storage/provider/src/providers/database/provider.rs

…igmxyz/reth into alexey/receipts-log-filter-is-back

jenpaff · 2025-11-27T12:24:11Z

@shekhirin can we close this PR? I see the linked issue was closed also

emmajam · 2026-02-11T14:32:09Z

@shekhirin do we still want this?

shekhirin · 2026-02-24T20:51:08Z

No one needs this

shekhirin added 2 commits November 10, 2025 13:11

feat(provider, prune): return receipts log filter

8ad4c18

validate config

6fbdb82

github-project-automation bot added this to Reth Tracker Nov 10, 2025

shekhirin added C-enhancement New feature or request A-db Related to the database A-pruning Related to pruning or full node labels Nov 10, 2025

github-project-automation bot moved this to Backlog in Reth Tracker Nov 10, 2025

update book

09e1a85

shekhirin force-pushed the alexey/receipts-log-filter-is-back branch from a83211e to b64b8ad Compare November 10, 2025 15:42

use alloc in prune-types

39c1f0e

shekhirin force-pushed the alexey/receipts-log-filter-is-back branch from b64b8ad to 39c1f0e Compare November 10, 2025 15:45

shekhirin added 2 commits November 10, 2025 16:24

validate, fix, and warn

6225498

tests

2d9300f

shekhirin force-pushed the alexey/receipts-log-filter-is-back branch from af63c54 to 2d9300f Compare November 10, 2025 16:45

shekhirin added 2 commits November 10, 2025 17:18

unify all receipts pruning checks into one fn

6c484b0

better error

5256e00

shekhirin force-pushed the alexey/receipts-log-filter-is-back branch from a928c07 to 5256e00 Compare November 10, 2025 17:25

shekhirin added 4 commits November 10, 2025 17:27

just impl custom deserialize

bd319c6

merge receipts log filter with config

4799939

fix static files copy condition

260581b

gate tracing behidn std in reth-prune-types

dd1190f

shekhirin marked this pull request as ready for review November 10, 2025 22:39

shekhirin requested review from Rjected, gakonst, joshieDo, klkvr, mattsse, mediocregopher and rakita as code owners November 10, 2025 22:39

Merge remote-tracking branch 'origin/main' into alexey/receipts-log-f…

a02168f

…ilter-is-back

mattsse requested changes Nov 10, 2025

View reviewed changes

github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Nov 10, 2025

reorder types, add docs

e679fbd

shekhirin force-pushed the alexey/receipts-log-filter-is-back branch from e0b9e21 to e679fbd Compare November 10, 2025 23:18

shekhirin requested a review from mattsse November 10, 2025 23:18

joshieDo reviewed Nov 10, 2025

View reviewed changes

crates/prune/types/src/target.rs Outdated Show resolved Hide resolved

Update crates/prune/types/src/target.rs

c03ba46

Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com>

joshieDo reviewed Nov 10, 2025

View reviewed changes

crates/storage/provider/src/providers/database/provider.rs Outdated Show resolved Hide resolved

shekhirin added 2 commits November 10, 2025 23:32

remove unneeded trait bound

9e05020

Merge branch 'alexey/receipts-log-filter-is-back' of github.com:parad…

349c26a

…igmxyz/reth into alexey/receipts-log-filter-is-back

shekhirin marked this pull request as draft November 10, 2025 23:51

do not preserve receipts close to tip

d5fc327

joshieDo mentioned this pull request Nov 13, 2025

feat: always write receipts to static files on new nodes #19399

Merged

mattsse force-pushed the main branch from 3cad676 to 0f3d369 Compare January 10, 2026 15:16

shekhirin closed this Feb 24, 2026

github-project-automation bot moved this from In Progress to Done in Reth Tracker Feb 24, 2026

mediocregopher deleted the alexey/receipts-log-filter-is-back branch February 25, 2026 17:12

		@@ -84,2 +83,2 @@
		.segment_opt(receipts.map(UserReceipts::new))

Conversation

shekhirin commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging #19630 will improve performances by 33.22%

Summary

Benchmarks breakdown

Uh oh!

mattsse left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joshieDo Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jenpaff commented Nov 27, 2025

Uh oh!

emmajam commented Feb 11, 2026

Uh oh!

shekhirin commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shekhirin commented Nov 10, 2025 •

edited

Loading

codspeed-hq bot commented Nov 10, 2025 •

edited

Loading

joshieDo Nov 10, 2025 •

edited

Loading