fix(op): Optionally disable op feature for reth-optimism-primitives #19018
Closed
fix(op): Optionally disable op feature for reth-optimism-primitives #19018
op feature for reth-optimism-primitives #19018Conversation
Collaborator
Author
|
@meyer9 @dhyaniarun1993 does the proof window work stream use the impl of any of these traits on |
emhane
requested review from
RomanHodulak,
joshieDo and
rakita
as code owners
Collaborator
Author
|
closing as not needed, but still wondering if it makes sense to move some of those traits out of reth... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it possible to disable
opfeature in crates that don't use implementations of following traits forop-alloytypes:CompactPayloadAttributesBuilderTransactionEnvExecutionPayloadPayloadAttributesSerdeBincodeCompatInMemorySizeFromConsensusTxTryIntoTxEnvTryIntoSimTxTryFromReceiptResponseSignableTxRequestTryFromTransactionResponseCompressDecompressCurrently most crates that use
reth-primitives-traitsdon't have anopfeature leading to failing lint for obscure reasons when adding optimism crates, hence would be good to have option to disableopfeature.