fix(deps): Optionally enable op feature for reth-optimism-primitives#242
Closed
fix(deps): Optionally enable op feature for reth-optimism-primitives#242
op feature for reth-optimism-primitives#242Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes dependency management for the reth-optimism-primitives crate by introducing an optional op feature. The changes ensure consistent feature enablement across the codebase when working with Optimism-specific functionality.
- Introduced a new
opfeature toreth-optimism-primitivescrate - Updated dependency declarations to optionally enable the
opfeature where needed - Added feature guards to implementation code to prevent compilation issues when the feature is disabled
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/optimism/primitives/Cargo.toml | Adds new op feature and updates dependency specifications |
| crates/optimism/primitives/src/lib.rs | Adds feature guard for NodePrimitives implementation |
| crates/storage/db-api/Cargo.toml | Updates feature dependency to optionally enable op feature |
| crates/rpc/rpc-convert/Cargo.toml | Updates feature dependency to optionally enable op feature |
| crates/optimism/node/Cargo.toml | Removes hardcoded reth-codec feature dependency |
| crates/optimism/evm/Cargo.toml | Explicitly enables op feature for required dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
op-will
approved these changes
Oct 15, 2025
Author
|
realised that |
Author
|
closing in favour or #250 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241
The
opfeature exists in reth to be able to implement traits defined in reth onop-alloytypes. The intermediary trie nodes store doesn't use thoseop-alloy-types, it operates on hashed dataRef paradigmxyz#19018