Merged
Conversation
Tool-aided by [comby-rust](https://github.com/huitseeker/comby-rust).
huitseeker
requested review from
Rjected,
gakonst,
joshieDo,
mattsse,
onbjerg,
rakita and
rkrasiuk
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1833 +/- ##
=======================================
Coverage 73.50% 73.51%
=======================================
Files 410 410
Lines 50510 50486 -24
=======================================
- Hits 37129 37115 -14
+ Misses 13381 13371 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
onbjerg
changed the title
onbjerg
requested changes
Mar 18, 2023
| }; | ||
| let Some(head) = self.client.header(&head_block_hash)? else { | ||
| // Block is not known, nothing to do | ||
| return Ok(ForkchoiceUpdated::from_status(PayloadStatusEnum::Syncing)) }; |
Collaborator
There was a problem hiding this comment.
Can you indent this? Seems weird that no linter caught it
| return Ok(ForkchoiceUpdated::from_status(PayloadStatusEnum::Invalid { | ||
| let Some(head_td) = self.client.header_td(&head_block_hash)? else { | ||
| // internal error - we have the head block but not the total difficulty | ||
| return Ok(ForkchoiceUpdated::from_status(PayloadStatusEnum::Invalid { |
Collaborator
|
Oops, sorry for merging this prematurely @onbjerg . looks like ruftmt has problems formatting let else? |
Collaborator
|
Looks like it. A bit annoying |
onbjerg
added a commit
that referenced
this pull request
Mar 18, 2023
onbjerg
added a commit
that referenced
this pull request
Mar 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opinion on those refactors loosely held, happy to accomodate. But some of the same was recently merged in #1810, so I thought this rounds things up a bit.