Merged
Conversation
rkrasiuk
requested review from
gakonst,
joshieDo,
onbjerg and
rakita
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1810 +/- ##
==========================================
- Coverage 73.47% 73.47% -0.01%
==========================================
Files 405 405
Lines 50323 50326 +3
==========================================
Hits 36976 36976
- Misses 13347 13350 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattsse
requested changes
Mar 17, 2023
| pre_state.into_iter().try_for_each(|(address, account)| -> eyre::Result<()> { | ||
| let has_code = !account.code.is_empty(); | ||
| let code_hash = if has_code { Some(keccak256(&account.code)) } else { None }; | ||
| let code_hash = has_code.then_some(keccak256(&account.code)); |
Collaborator
There was a problem hiding this comment.
I don't think these are euqivalent beecause then_some takes the value.
I think this should be just .then with a closure
mattsse
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer
bool::then_someoverif <bool> { Some(..) } else { None }