Skip to content

feat(rpc): Add EvmEnvConverter for custom effects on the EvmEnv#17940

Closed
RomanHodulak wants to merge 1 commit intomainfrom
rpc-evm-env-convert
Closed

feat(rpc): Add EvmEnvConverter for custom effects on the EvmEnv#17940
RomanHodulak wants to merge 1 commit intomainfrom
rpc-evm-env-convert

Conversation

@RomanHodulak
Copy link
Contributor

Closes #17935

Adds a new converter to RpcConvert that can apply custom effects on the EvmEnv.

The conversion is EvmEnv -> EvmEnv meaning there is no different type at the output.

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Aug 19, 2025
@github-actions github-actions bot added A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library C-enhancement New feature or request labels Aug 19, 2025
@RomanHodulak RomanHodulak marked this pull request as ready for review August 19, 2025 13:58
@mattsse mattsse requested a review from klkvr August 25, 2025 14:16
Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simply an override so I think EvmEnvOverrides/RpcEnvOverrides would be a better name here?

Also it seems that #17935 suggests extracting entire prepare_call_env logic into the overridable handler so would like a review from @mattsse here

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after looking at #17792 again this is basically a subset of this and we solved #17935 differently

@mattsse mattsse closed this Sep 1, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Reth Tracker Sep 1, 2025
@mediocregopher mediocregopher deleted the rpc-evm-env-convert branch February 25, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rpc Related to the RPC implementation A-sdk Related to reth's use as a library C-enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Make TxEnv call env conversion configurable

3 participants