eip2930: use alloy TxEip2930

[tcoratger]

Related #9484

[tcoratger]

@klkvr Seems like we have an overflow issue here in the proptest, I imagine with the gas_limit. I've seen for example in the log

 transaction: Eip2930(
                TxEip2930 {
                    chain_id: 3291341489588165751,
                    nonce: 14906479109494292543,
                    gas_price: 55689700555394906303085696969414843071,
                    gas_limit: 318428246144358250530485492401114899755,
                    to: Create,
                    value: 66313936203721210645241833585571478386497671455018825453644050639460415969048,
                    access_list: AccessList(
                        [],
                    ),
                    input: 0x,
                },
            ),

I imagine that this is due to the proptest which generates a random u128 for the gas_limit but this cannot be converted to u64 then, I think it's the issue here...

On alloy side, do we really need the gas limit to be u128 or could we move to u64?

[klkvr]

yeah, for now we've added workaround in Transaction arbitrary impl for handling this:

reth/crates/primitives/src/transaction/mod.rs

Line 156 in e18a46d

if let Self::Legacy(tx) = &mut tx {

it is not great but fine for now I think

On alloy side, do we really need the gas limit to be u128 or could we move to u64?

In alloy we've set gas limit to u128 everywhere on purpose and agreed that it makes sense at some point: alloy-rs/alloy#454

But given both reth and revm seem to handle it as u64 everywhere I am wondering if there's new context/convention we should follow in alloy as well @mattsse ?

[klkvr]

overall lgtm, couple notes on tests