Skip to content

eip2930: add payload methods for TxEip2930#1218

Closed
tcoratger wants to merge 3 commits intoalloy-rs:mainfrom
tcoratger:TxEip2930
Closed

eip2930: add payload methods for TxEip2930#1218
tcoratger wants to merge 3 commits intoalloy-rs:mainfrom
tcoratger:TxEip2930

Conversation

@tcoratger
Copy link
Copy Markdown
Contributor

@mattsse
Copy link
Copy Markdown
Member

mattsse commented Aug 30, 2024

looks like we need to bump msrv

@tcoratger
Copy link
Copy Markdown
Contributor Author

looks like we need to bump msrv

@mattsse done here #1219

Copy link
Copy Markdown
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptal @klkvr

@klkvr
Copy link
Copy Markdown
Member

klkvr commented Aug 30, 2024

hmm, not sure we need those? we already have encoded_len_with_signature and encode_with_signature which accept with_header: bool

@tcoratger
Copy link
Copy Markdown
Contributor Author

Oh that's true thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants