Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rawboxscore.xml to stats retrieval, fixes #30 #58

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Add rawboxscore.xml to stats retrieval, fixes #30 #58

merged 2 commits into from
Jan 30, 2018

Conversation

ajbowler
Copy link
Contributor

@ajbowler ajbowler commented Jan 30, 2018

This adds the data retrieved from rawboxscore.xml to player_stats and team_stats. The data is mostly the same but rawboxscore.xml contains the groundouts and flyouts for each pitcher, go and ao respectively.

Why MLB decided it was worth having two XMLs for the box score I'll never know.

Would appreciate code reviews, since I'm not a Python expert.

  • Crosscheck Away batting? #57 and see if it's still an issue. If it requires a larger fix, will be done outside of this PR.
  • Log new issue for stats.py getting really big. The team stats and player stats can have their own files.

@ajbowler
Copy link
Contributor Author

The existing master build is failing so let me know what you want me to change based on build results.

@panzarino
Copy link
Owner

@ajbowler The build is failing because of a different issue, nothing that you have done wrong. Looks pretty good to me, I'll review it more closely soon and then merge. By chance, did you also fix #57 in this too?

@ajbowler
Copy link
Contributor Author

I haven't checked #57 yet, I'll do that as part of this PR. Adding a checklist to the OP

@ajbowler
Copy link
Contributor Author

#57 was a small change, so I added it as part of this PR. Would appreciate not squashing these since they're separate issues.

@ajbowler
Copy link
Contributor Author

Also logged #59

@panzarino
Copy link
Owner

panzarino commented Jan 30, 2018

@ajbowler Thanks for fixing #57, just a lazy mistake when I was refactoring the method. Merging now, I'm aiming for another release by this weekend that should fix some errors (including the broken builds) and implement this new feature.

@panzarino panzarino merged commit 00775ce into panzarino:master Jan 30, 2018
@ajbowler ajbowler deleted the raw-box-score branch January 30, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants