Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groundouts-flyouts in pitcher results? #30

Closed
FlowFX opened this issue May 7, 2017 · 7 comments
Closed

Groundouts-flyouts in pitcher results? #30

FlowFX opened this issue May 7, 2017 · 7 comments

Comments

@FlowFX
Copy link

FlowFX commented May 7, 2017

On mlb.com, they show the number of flyouts and groundouts for each pitcher.

screen shot 2017-05-07 at 09 43 01

I can't find these in the player_stats. Does the API provide this information at all?

@panzarino
Copy link
Owner

@FlowFX I am not sure, I will check it out.

@trevor-viljoen
Copy link
Contributor

trevor-viljoen commented May 11, 2017

@panzarino rawboxscore.xml contains that info.
go and ao

<pitcher bam_s_er="21" bam_bs="0" hr="2" bam_hld="0" bis_bs="0" np="90" name_display_first_last="Joe Musgrove" game_score="48" pos="P" id="605397" bis_l="3" bam_l="3" bk="0" bis_w="2" name="Musgrove" bf="22" bis_era="5.02" bb="3" bam_s_so="28" bam_s_bb="13" bam_w="2" so="4" bis_hld="0" bam_s_r="22" win="true" pitch_order="100" h="4" bis_s_r="22" bam_s_ip="37.2" bam_era="5.02" bis_s_so="28" bis_s_h="39" bis_s_ip="37.2" bam_s_h="39" s="55" ao="0" bis_sv="0" r="2" bis_s_er="21" bam_sv="0" bis_s_bb="13" er="2" out="18" go="10">

@ajbowler
Copy link
Contributor

@panzarino @trevor-viljoen I'd like to take a crack at this if you're cool with adding the feature.

I looked through the XMLs and indeed rawboxscore.xml is the only place I can find groundouts/flyouts (GO/AO). Do you have any concerns about adding the extra network call/XML tree parse?

@panzarino
Copy link
Owner

@ajbowler Go for it! Would love to have a new feature for the library. For larger features, please try to keep the format similar to the way that the current functions work (although the design is not the best, I want to keep it consistent at this point).

@ajbowler
Copy link
Contributor

I'll add the two stats to the existing player_stats call, I'm not seeing any additional stats the extra XML file gives us at the moment but I'll keep an eye out and open new issues if the data contains any further value

@panzarino
Copy link
Owner

@ajbowler If you're changing the player_stats call could you also look at #57? If not, I can fix it but I figured it would be an easy fix and you would need that to work in order to properly test anyway.

@ajbowler
Copy link
Contributor

It shouldn't impact either way since I'm grabbing stuff off the pitchers instead of the batters, but I can take a look while I'm in there.

panzarino added a commit that referenced this issue Jan 30, 2018
Add rawboxscore.xml to stats retrieval, fixes #30 and #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants