Require urllib3<2, to reduce installation issues#18959
Closed
huonw wants to merge 2 commits intopantsbuild:mainfrom
Closed
Require urllib3<2, to reduce installation issues#18959huonw wants to merge 2 commits intopantsbuild:mainfrom
huonw wants to merge 2 commits intopantsbuild:mainfrom
Conversation
huonw
added
needs-cherrypick
huonw
requested review from
Eric-Arellano,
benjyw,
cognifloyd,
kaos,
stuhood and
thejcannon
stuhood
approved these changes
May 9, 2023
thejcannon
approved these changes
May 9, 2023
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Contributor
Author
huonw
added a commit
that referenced
this pull request
May 11, 2023
…) (#18971) The release of urllib3 2 has caused issues with installing pants (e.g. it requires OpenSSL 1.1.1), so, for now, we can restrict to only working with urllib3 1.x.y and thus reduce how often people have to apply workarounds like `PIP_CONSTRAINTS=...`. I've verified that the wheel `METADATA` has `Requires-Dist: urllib3 (<2)`, and installing the wheel into a fresh venv _before_ uses `urllib3==2.0.2`, while installing the wheel _after_ uses `urllib3==1.26.15`. This patch is intended to be an option for a short term/focused work-around that is safe to cherry-pick back to older branches, while #18952 is the better fix (removes the use of urllib3 from the main wheel) but riskier, and thus might not be cherry-picked. Background: https://pantsbuild.slack.com/archives/C0D7TNJHL/p1683644499629429
huonw
added a commit
that referenced
this pull request
May 11, 2023
…) (#18973) The release of urllib3 2 has caused issues with installing pants (e.g. it requires OpenSSL 1.1.1), so, for now, we can restrict to only working with urllib3 1.x.y and thus reduce how often people have to apply workarounds like `PIP_CONSTRAINTS=...`. I've verified that the wheel `METADATA` has `Requires-Dist: urllib3 (<2)`, and installing the wheel into a fresh venv _before_ uses `urllib3==2.0.2`, while installing the wheel _after_ uses `urllib3==1.26.15`. This patch is intended to be an option for a short term/focused work-around that is safe to cherry-pick back to older branches, while #18952 is the better fix (removes the use of urllib3 from the main wheel) but riskier, and thus might not be cherry-picked. Background: https://pantsbuild.slack.com/archives/C0D7TNJHL/p1683644499629429
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release of urllib3 2 has caused issues with installing pants (e.g. it requires OpenSSL 1.1.1), so, for now, we can restrict to only working with urllib3 1.x.y and thus reduce how often people have to apply workarounds like
PIP_CONSTRAINTS=....I've verified that the wheel
METADATAhasRequires-Dist: urllib3 (<2), and installing the wheel into a fresh venv before usesurllib3==2.0.2, while installing the wheel after usesurllib3==1.26.15.This patch is intended to be an option for a short term/focused work-around that is safe to cherry-pick back to older branches, while #18952 is a better fix (removes the use of urllib3 from the main wheel) but riskier, and thus might not be cherry-picked.
Background: https://pantsbuild.slack.com/archives/C0D7TNJHL/p1683644499629429