Skip to content

Require urllib3<2, to reduce installation issues #18959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huonw wants to merge 2 commits into from
Closed

Require urllib3<2, to reduce installation issues #18959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04562f0
Require urllib3<2, to reduce installation issues
huonw May 9, 2023
87a1a37
Update 3rdparty/python/requirements.txt
huonw May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 3rdparty/python/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ python_requirements(
"node-semver": ["nodesemver"],
},
overrides={
"humbug": {"dependencies": ["#setuptools"]},
"humbug": {"dependencies": ["#setuptools", "#urllib3"]},
},
)

Expand Down
4 changes: 4 additions & 0 deletions 3rdparty/python/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ freezegun==1.2.1
# anonymity promise we make here: https://www.pantsbuild.org/docs/anonymous-telemetry
humbug==0.2.7

# `humbug` requires `requests` which requires `urllib3`. This breaks some users, so workaround for now is to
# pin urllib3
urllib3<2

importlib_resources==5.0.*
ijson==3.1.4
packaging==21.3
Expand Down
Loading