Skip to content

Conversation

@mroeschke
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke requested a review from MarcoGorelli as a code owner July 17, 2023 21:09
@mroeschke mroeschke added Dependencies Required and optional dependencies Unreliable Test Unit tests that occasionally fail labels Jul 17, 2023
@mroeschke mroeschke added this to the 2.0.4 milestone Jul 17, 2023
@mroeschke mroeschke mentioned this pull request Apr 22, 2022
10 tasks
@mroeschke
Copy link
Member Author

Looks like tests are passing here. I just modified the test so that it passes with cython3 and cython0.29. I made a note in #34213 of the core issue that would need to be addressed for cython3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Required and optional dependencies Unreliable Test Unit tests that occasionally fail

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant