-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
Closed
Labels
Description
Collecting TODOs for once we bump to cython3:
- use conditional nogil e.g. here
- change labels.shape[0] -> len(labels) e.g. groupbyL965
- update
searchsortedusages to use fixed cython version - Move Timestamp methods to _Timestamp, assuming Change default of "always_allow_keywords" directive to True cython/cython#3605 is merged
- in
_libs.internalsusefrom cpython.pyport cimport PY_SSIZE_T_MAXinstead ofcdef extern ... - in
_libs.utilusefrom numpy cimport PyArray_CLEARFLAGS, NPY_ARRAY_C_CONTIGUOUS, NPY_ARRAY_F_CONTIGUOUSinstead ofcdef extern ... - in
_libs.parsersusefrom cpython.unicode cimport PyUnicode_FromStringinstead ofcdef extern ... - in
tslibs.parsingreplacePyObject_Strwithstr(xref Optimize builtin str calls cython/cython#3478) -
from numpy cimport NPY_DATETIMEUNIT - Audit usages of
arg : datetimeannotations in tslibs. Can interfere with non-nano usages ofTimestamp(xref DEBUG: CY3 test_add_out_of_pydatetime_range #54169)
@WillAyd am i missing anything (const object[:]?)? If so, go ahead and edit the OP.