Series.astype(np.integer) doesn't show numpy warning #51917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Mar 13, 2023
pandas/tests/dtypes/test_common.py
Outdated
|
|
||
| def test_pandas_dtype_numpy_warning(): | ||
| # GH#51523 | ||
| with warnings.catch_warnings(record=True) as w: |
Member
There was a problem hiding this comment.
can you do tm.assert_produces_warning() instead?
Contributor
Author
There was a problem hiding this comment.
sure thing, I've updated the testcase.
phofl
approved these changes
Mar 13, 2023
mroeschke
approved these changes
Mar 14, 2023
Member
|
Thanks @dannyi96 |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 14, 2023
mroeschke
pushed a commit
that referenced
this pull request
Mar 14, 2023
… show numpy warning) (#51958) Backport PR #51917: Series.astype(np.integer) doesn't show numpy warning Co-authored-by: Daniel Isaac <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.