Backport PR #51917 on branch 2.0.x (Series.astype(np.integer) doesn't show numpy warning) (#51958)

Backport PR #51917: Series.astype(np.integer) doesn't show numpy warning

Co-authored-by: Daniel Isaac <[email protected]>

Author: meeseeksmachine

pandas/core/dtypes/common.py

@@ -7,6 +7,7 @@
     Any,
     Callable,
 )
+import warnings
 
 import numpy as np
 
@@ -1678,7 +1679,12 @@ def pandas_dtype(dtype) -> DtypeObj:
     # try a numpy dtype
     # raise a consistent TypeError if failed
     try:
-        npdtype = np.dtype(dtype)
+        with warnings.catch_warnings():
+            # GH#51523 - Series.astype(np.integer) doesn't show
+            # numpy deprication warning of np.integer
+            # Hence enabling DeprecationWarning
+            warnings.simplefilter("always", DeprecationWarning)
+            npdtype = np.dtype(dtype)
     except SyntaxError as err:
         # np.dtype uses `eval` which can raise SyntaxError
         raise TypeError(f"data type '{dtype}' not understood") from err

pandas/tests/dtypes/test_common.py

@@ -754,3 +754,13 @@ def test_validate_allhashable():
 
     with pytest.raises(TypeError, match="list must be a hashable type"):
         com.validate_all_hashable([], error_name="list")
+
+
+def test_pandas_dtype_numpy_warning():
+    # GH#51523
+    with tm.assert_produces_warning(
+        DeprecationWarning,
+        check_stacklevel=False,
+        match="Converting `np.integer` or `np.signedinteger` to a dtype is deprecated",
+    ):
+        pandas_dtype(np.integer)