Skip to content

Fixed mypy errors in frequencies.py #47644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 8, 2022
Merged

Fixed mypy errors in frequencies.py #47644

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0097f75
TST: Added test for consistent type with unique agg #22558
srotondo Jul 5, 2022
1d695b1
Merge remote-tracking branch 'upstream/main' into unique-test
srotondo Jul 5, 2022
06db464
TST: Added test for consistent type with unique agg #22558
srotondo Jul 5, 2022
f977a15
TST: Moved and restructured test #22558
srotondo Jul 6, 2022
e5f517f
TYP: Fixed mypy issues in frequencies
srotondo Jul 8, 2022
b2432d7
TYP: Removed accidental inclusion
srotondo Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions pandas/tseries/frequencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,11 +394,11 @@ def _get_annual_rule(self) -> str | None:
return None

pos_check = self.month_position_check()
# error: Argument 1 to "get" of "dict" has incompatible type
# "Optional[str]"; expected "str"
return {"cs": "AS", "bs": "BAS", "ce": "A", "be": "BA"}.get(
pos_check # type: ignore[arg-type]
)

if pos_check is None:
return None
else:
return {"cs": "AS", "bs": "BAS", "ce": "A", "be": "BA"}.get(pos_check)

def _get_quarterly_rule(self) -> str | None:
if len(self.mdiffs) > 1:
Expand All @@ -408,21 +408,21 @@ def _get_quarterly_rule(self) -> str | None:
return None

pos_check = self.month_position_check()
# error: Argument 1 to "get" of "dict" has incompatible type
# "Optional[str]"; expected "str"
return {"cs": "QS", "bs": "BQS", "ce": "Q", "be": "BQ"}.get(
pos_check # type: ignore[arg-type]
)

if pos_check is None:
return None
else:
return {"cs": "QS", "bs": "BQS", "ce": "Q", "be": "BQ"}.get(pos_check)

def _get_monthly_rule(self) -> str | None:
if len(self.mdiffs) > 1:
return None
pos_check = self.month_position_check()
# error: Argument 1 to "get" of "dict" has incompatible type
# "Optional[str]"; expected "str"
return {"cs": "MS", "bs": "BMS", "ce": "M", "be": "BM"}.get(
pos_check # type: ignore[arg-type]
)

if pos_check is None:
return None
else:
return {"cs": "MS", "bs": "BMS", "ce": "M", "be": "BM"}.get(pos_check)

def _is_business_daily(self) -> bool:
# quick check: cannot be business daily
Expand Down