Fixed mypy errors in frequencies.py #47644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Shoot, looks like I accidentally left a change from one of my previous PRs in here, I'll fix that |
mroeschke
approved these changes
Jul 8, 2022
Member
|
Thanks @srotondo |
twoertwein
approved these changes
Jul 8, 2022
Member
twoertwein
left a comment
twoertwein
left a comment
There was a problem hiding this comment.
Would also be fine with keeping it as-is and waiting for python/typeshed#8219 allowing any object in .get
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TST: Added test for consistent type with unique agg pandas-dev#22558 * TST: Added test for consistent type with unique agg pandas-dev#22558 * TST: Moved and restructured test pandas-dev#22558 * TYP: Fixed mypy issues in frequencies * TYP: Removed accidental inclusion Co-authored-by: Steven Rotondo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.