Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: groupby.pyi #40716

Merged
merged 2 commits into from
Apr 2, 2021
Merged

TYP: groupby.pyi #40716

merged 2 commits into from
Apr 2, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added Groupby Typing type annotations, mypy/pyright type checking labels Apr 1, 2021
@jreback jreback added this to the 1.3 milestone Apr 1, 2021
@jreback
Copy link
Contributor

jreback commented Apr 1, 2021

@jbrockmendel you may have answered this, but how do we tests / keep these up to date?

@jbrockmendel
Copy link
Member Author

but how do we tests / keep these up to date?

@simonjayhawkins has a branch (though i dont see a PR) that implements tests, but im not sure exactly how that works. as for keeping it up to date: manually

@jreback jreback merged commit fa2da60 into pandas-dev:master Apr 2, 2021
@jbrockmendel jbrockmendel deleted the typ-libgb-2 branch April 2, 2021 01:41
@simonjayhawkins
Copy link
Member

@simonjayhawkins has a branch (though i dont see a PR) that implements tests

#40202 - closed until after arrow string array is further progressed.

@simonjayhawkins
Copy link
Member

as for keeping it up to date: manually

related issue #28133

vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants