BUG: scalar indexing on 2D DTA/TDA/PA #33342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndas-dev#33265) * add test on date range timezone reindex * undo * fix * move code to datetime test * import timedelta * adding assertion the np array results * comply to coding standard * update * update * assert_numpy_array_equal * comply black format * format checking * white space * bleck
Co-authored-by: MomIsBestFriend <>
jbrockmendel
added
Bug
Indexing
Member
|
@jbrockmendel now #33290 is merged, this can be updated / merged? |
jorisvandenbossche
approved these changes
Apr 10, 2020
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
This looks good to me, thanks!
Member
Author
This is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jorisvandenbossche this fixes the issue with
DatetimeLikeBlockMixin.igetdiscussed in #33252Note: this sits on top of #33290.