Skip to content

Conversation

@BenjaminLiuPenrose
Copy link
Contributor

@BenjaminLiuPenrose BenjaminLiuPenrose commented Apr 3, 2020

@ShaharNaveh ShaharNaveh added the Testing pandas testing functions or related to the test suite label Apr 3, 2020
@WillAyd
Copy link
Member

WillAyd commented Apr 3, 2020

Thanks for the PR! I think this is already covered here though?

def test_constructor_tuple(self, tuples, lists):

If not, probably should just add to the parametrization there instead of creating a new test

@BenjaminLiuPenrose
Copy link
Contributor Author

Thanks for the PR! I think this is already covered here though?

def test_constructor_tuple(self, tuples, lists):

If not, probably should just add to the parametrization there instead of creating a new test

It is not covered. Will add to the param list instead

@mroeschke mroeschke added this to the 1.1 milestone Apr 4, 2020
@WillAyd WillAyd merged commit 3c843d6 into pandas-dev:master Apr 4, 2020
@WillAyd
Copy link
Member

WillAyd commented Apr 4, 2020

Great thanks @BenjaminLiuPenrose

@BenjaminLiuPenrose
Copy link
Contributor Author

glad that I can help contribute to this amazing project ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash with access violation (exit code -1073741819 (0xC0000005)) on Windows 10

4 participants