TST: Enable Index dtype comparison by default #11588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
force-pushed
the
test_idxtype
branch
from
bc5bc0a to
7ecb409
Compare
jreback
added a commit
that referenced
this pull request
Nov 17, 2015
TST: Enable Index dtype comparison by default
|
thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
check_index_typeandcheck_columns_typeby default to detect dtype related problems.Fixed following 2 minor bugs at the same time, but I'm willing to split them to separate PR if required.
1.
Series.quantilewith empty list results inobjectindex rather thanfloat.2.
pd.mergeincludes empty data may result inInt64Indexrather thanobjectSorry, #10826 was incomplete.
When fixing #11497, #11586, we can enable corresponding
check_index_type